[
https://issues.apache.org/jira/browse/DRILL-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593075#comment-16593075
]
ASF GitHub Bot commented on DRILL-6709:
---------------------------------------
sachouche commented on a change in pull request #1444: DRILL-6709: Extended the
batch stats utility to other operators
URL: https://github.com/apache/drill/pull/1444#discussion_r212842963
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
##########
@@ -204,7 +204,12 @@ public HashAggBatch(HashAggregate popConfig, RecordBatch
incoming, FragmentConte
}
hashAggMemoryManager = new HashAggMemoryManager(configuredBatchSize);
- logger.debug("BATCH_STATS, configured output batch size: {}",
configuredBatchSize);
+
+ if (isRecordBatchStatsLoggingEnabled()) {
Review comment:
I agree with your feedback; I was anyway going to make this improvement as I
didn't like the extra condition. I added another method which takes a string
format and variable arguments; modified most of the previous calls to use this
method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Batch statistics logging utility needs to be extended to mid-stream operators
> -----------------------------------------------------------------------------
>
> Key: DRILL-6709
> URL: https://issues.apache.org/jira/browse/DRILL-6709
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Robert Hou
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> A new batch logging utility has been created to log batch sizing messages to
> drillbit.log. It is being used by the Parquet reader. It needs to be enhanced
> so it can be used by mid-stream operators. In particular, mid-stream
> operators have both incoming batches and outgoing batches, while Parquet only
> has outgoing batches. So the utility needs to support incoming batches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
