[
https://issues.apache.org/jira/browse/DRILL-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593072#comment-16593072
]
ASF GitHub Bot commented on DRILL-6709:
---------------------------------------
sachouche commented on a change in pull request #1444: DRILL-6709: Extended the
batch stats utility to other operators
URL: https://github.com/apache/drill/pull/1444#discussion_r212843653
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/util/record/RecordBatchStats.java
##########
@@ -279,4 +324,19 @@ private static void
logBatchStatsMsg(RecordBatchStatsContext batchStatsContext,
}
}
+ private static String toString(BatchIOType ioType) {
+ Preconditions.checkNotNull(ioType, "The record batch IO type cannot be
null");
+
+ switch (ioType) {
Review comment:
I have seen both types of indentation being used; I have implemented your
suggestion.
and yes, I am aware that Java enums are more powerful; for now didn't have a
need to enhance it. I have a added a private variable IOTypeString in case
caller wants to get the string representation. Didn't use this in the code as I
wanted to avoid expensive string concatenation (especially now that the caller
is not using the isStatsLoggingEnabled() check).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch statistics logging utility needs to be extended to mid-stream operators
> -----------------------------------------------------------------------------
>
> Key: DRILL-6709
> URL: https://issues.apache.org/jira/browse/DRILL-6709
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Robert Hou
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> A new batch logging utility has been created to log batch sizing messages to
> drillbit.log. It is being used by the Parquet reader. It needs to be enhanced
> so it can be used by mid-stream operators. In particular, mid-stream
> operators have both incoming batches and outgoing batches, while Parquet only
> has outgoing batches. So the utility needs to support incoming batches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
