[
https://issues.apache.org/jira/browse/DRILL-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056172#comment-17056172
]
ASF GitHub Bot commented on DRILL-7634:
---------------------------------------
paul-rogers commented on pull request #2020: DRILL-7634: Rollup of code cleanup
changes
URL: https://github.com/apache/drill/pull/2020
# [DRILL-7634](https://issues.apache.org/jira/browseDRILL-7634): Rollup of
code cleanup changes
## Description
Collection of code cleanup changes.
The most significant is to create constants for function names. We already
had a pretty good list in `FunctionGenerationHelper`. I move this list to a new
interface, `FunctionNames` and added to it. I then changed all references to
hard-coded names to instead refer to these constants.
This change pointed out several places where code checks for variations of
function names. Not sure why; perhaps an early version of the code did not have
the map from alias to "canonical" name. Used constants for the canonical name,
left the other names in place because I don't have enough knowledge to know if
it is safe to remove them. Anyone know?
Also made the `args` member of `FunctionCall` private and added accessors.
## Documentation
None
## Testing
Reran all unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rollup of code cleanup changes
> ------------------------------
>
> Key: DRILL-7634
> URL: https://issues.apache.org/jira/browse/DRILL-7634
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.18.0
>
>
> Pack of cosmetic code cleanup changes accumulated over recent months.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
