[
https://issues.apache.org/jira/browse/DRILL-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056803#comment-17056803
]
ASF GitHub Bot commented on DRILL-7634:
---------------------------------------
vvysotskyi commented on pull request #2020: DRILL-7634: Rollup of code cleanup
changes
URL: https://github.com/apache/drill/pull/2020#discussion_r390847156
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPrel.java
##########
@@ -186,6 +188,7 @@ public boolean isSemiJoin() {
// fields, left fields, and right fields. Very similar to the
// output row type, except that fields have not yet been made due
// due to outer joins.
+ @SuppressWarnings("deprecation")
RexChecker checker =
new RexChecker(
getCluster().getTypeFactory().builder()
Review comment:
Please use Builder class, as it is recommended in the JavaDoc:
```suggestion
RexChecker checker =
new RexChecker(
new
RelDataTypeFactory.Builder(getCluster().getTypeFactory())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rollup of code cleanup changes
> ------------------------------
>
> Key: DRILL-7634
> URL: https://issues.apache.org/jira/browse/DRILL-7634
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.18.0
>
>
> Pack of cosmetic code cleanup changes accumulated over recent months.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
