[
https://issues.apache.org/jira/browse/DRILL-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056802#comment-17056802
]
ASF GitHub Bot commented on DRILL-7634:
---------------------------------------
vvysotskyi commented on pull request #2020: DRILL-7634: Rollup of code cleanup
changes
URL: https://github.com/apache/drill/pull/2020#discussion_r390833446
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java
##########
@@ -81,51 +79,47 @@ public boolean isAggregating() {
@Override
public JVar[] renderStart(ClassGenerator<?> g, HoldingContainer[]
inputVariables, FieldReference fieldReference) {
if (!g.getMappingSet().isHashAggMapping()) { //Declare workspace vars for
non-hash-aggregation.
- JVar[] workspaceJVars = declareWorkspaceVariables(g);
- generateBody(g, BlockType.SETUP, setup(), null, workspaceJVars, true);
- return workspaceJVars;
+ JVar[] workspaceJVars = declareWorkspaceVariables(g);
+ generateBody(g, BlockType.SETUP, setup(), null, workspaceJVars, true);
+ return workspaceJVars;
} else { //Declare workspace vars and workspace vectors for hash
aggregation.
Review comment:
Please fix indentation for this line also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rollup of code cleanup changes
> ------------------------------
>
> Key: DRILL-7634
> URL: https://issues.apache.org/jira/browse/DRILL-7634
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.18.0
>
>
> Pack of cosmetic code cleanup changes accumulated over recent months.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
