[
https://issues.apache.org/jira/browse/DRILL-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056807#comment-17056807
]
ASF GitHub Bot commented on DRILL-7634:
---------------------------------------
vvysotskyi commented on pull request #2020: DRILL-7634: Rollup of code cleanup
changes
URL: https://github.com/apache/drill/pull/2020#discussion_r390830839
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java
##########
@@ -65,9 +65,9 @@
OracleSqlOperatorTable.TRANSLATE3.getName().toLowerCase())
.build();
- private ArrayListMultimap<String, Class<? extends GenericUDF>>
methodsGenericUDF = ArrayListMultimap.create();
- private ArrayListMultimap<String, Class<? extends UDF>> methodsUDF =
ArrayListMultimap.create();
- private HashSet<Class<?>> nonDeterministicUDFs = new HashSet<>();
+ private final ArrayListMultimap<String, Class<? extends GenericUDF>>
methodsGenericUDF = ArrayListMultimap.create();
Review comment:
Nit: Could you please replace field type with the `Multimap` interface here
and in the line below.
```suggestion
private final Multimap<String, Class<? extends GenericUDF>>
methodsGenericUDF = ArrayListMultimap.create();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rollup of code cleanup changes
> ------------------------------
>
> Key: DRILL-7634
> URL: https://issues.apache.org/jira/browse/DRILL-7634
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.18.0
>
>
> Pack of cosmetic code cleanup changes accumulated over recent months.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
