yanrongzhen commented on code in PR #4544:
URL: https://github.com/apache/eventmesh/pull/4544#discussion_r1388168285
##########
eventmesh-runtime/build.gradle:
##########
@@ -72,6 +72,9 @@ dependencies {
implementation project(":eventmesh-webhook:eventmesh-webhook-api")
implementation project(":eventmesh-webhook:eventmesh-webhook-receive")
+ implementation project(":eventmesh-retry:eventmesh-retry-api")
+ implementation project(":eventmesh-retry:eventmesh-retry-rocketmq")
Review Comment:
I don't think this dependency should be removed. If it is removed, the SPI
will not take effect when the user specifies storage = rocketmq.
---
我觉得不应该删除此依赖, 如果删除, 当用户指定了storage=rocketmq的时候, 将不会生效此SPI.
##########
eventmesh-runtime/build.gradle:
##########
@@ -72,6 +72,9 @@ dependencies {
implementation project(":eventmesh-webhook:eventmesh-webhook-api")
implementation project(":eventmesh-webhook:eventmesh-webhook-receive")
+ implementation project(":eventmesh-retry:eventmesh-retry-api")
+ implementation project(":eventmesh-retry:eventmesh-retry-rocketmq")
Review Comment:
I don't think this dependency should be removed. If it is removed, the SPI
will not take effect when the user specifies storage = rocketmq.
---
我觉得不应该删除此依赖, 如果删除, 当用户指定了storage=rocketmq的时候, 将不会生效此SPI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
