yanrongzhen commented on code in PR #4544:
URL: https://github.com/apache/eventmesh/pull/4544#discussion_r1388179847
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
> Could `Timeout` in the `doRun (timeout)`<-- `run (timeout)` reserved for
`reput()` be removed ?
>
> 那为`rePut()`预留的`doRun(Timeout)` <-- `run(Timeout)`中的`Timeout`是不是可以删掉了？
Also, the rePut method I think will be re-added soon in the future, and it
is a common practice to resubmit to the hashed time wheel when the retry
process fails.
---
并且, rePut方法我认为在未来很快会被重新添加回来, 在重试过程中产生失败时, 重新提交到时间轮是一个很常见的做法.
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
> Could `Timeout` in the `doRun (timeout)`<-- `run (timeout)` reserved for
`reput()` be removed ?
>
> 那为`rePut()`预留的`doRun(Timeout)` <-- `run(Timeout)`中的`Timeout`是不是可以删掉了？
Also, the rePut method I think will be re-added soon in the future, and it
is a common practice to resubmit to the hashed time wheel when the retry
process fails.
---
并且, rePut方法我认为在未来很快会被重新添加回来, 在重试过程中产生失败时, 重新提交到时间轮是一个很常见的做法.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
