pandaapo commented on code in PR #4544:
URL: https://github.com/apache/eventmesh/pull/4544#discussion_r1388725828
##########
eventmesh-runtime/build.gradle:
##########
@@ -72,6 +72,9 @@ dependencies {
implementation project(":eventmesh-webhook:eventmesh-webhook-api")
implementation project(":eventmesh-webhook:eventmesh-webhook-receive")
+ implementation project(":eventmesh-retry:eventmesh-retry-api")
+ implementation project(":eventmesh-retry:eventmesh-retry-rocketmq")
Review Comment:
According to this comment
https://github.com/apache/eventmesh/pull/4544#discussion_r1387814835, adding a
backup strategy and adding log prompts is just to decouple runtime and specific
storage more thoroughly? If we implement retry-rabbitmq and retry-kafka in the
later stage, shouldn't we also include them?
When users see logs that have been selected as standalone or have not been
loaded into the SPI implementation, they naturally know that corresponding
dependencies need to be introduced. It can even make the logs clearer and
prompt users to introduce corresponding storage retry dependency or implement
their own SPI for storage retries.
To avoid further arguments, it's better to ask the maintainer to decide
whether to keep this dependency in runtime module. @xwm1992.
https://github.com/apache/eventmesh/blob/44484350365c28567f17c7d4ffc1c68232ce05f3/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/RetryContext.java#L68-L85
根据这条评论 https://github.com/apache/eventmesh/pull/4544#discussion_r1387814835
，增加兜底策略、增加日志提示，不就是为了runtime和具体的存储更彻底的解耦吗？后期如果实现了retry-rabbitmq、retry-kafka岂不是也要加进来？
当用户看到因为选择了standalone或者没有加载到SPI实现的日志时，自然就知道需要引入相应的依赖。甚至可以让日志更明确些，提示用户引入相应的存储重试依赖或者自己实现存储重试的SPI。
为了避免更多的争论，还是请maintainer来决定是否在runtime模块中保留该依赖吧。@xwm1992。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
