pandaapo commented on code in PR #4544:
URL: https://github.com/apache/eventmesh/pull/4544#discussion_r1388715716
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
> the rePut method I think will be re-added soon in the future
This is certainly very good. Could you add a `Timeout` parameter to
`doRun()` and `run()` when the `reput` is re-added? It is beneficial for both
the community and the project to keep open source code in a clear and tidy
state for iteration as much as possible.
这非常好。那能不能在`rePut`被重新添加回来时，再给`doRun()`和`run()`加上`Timeout`入参呢？让开源代码尽量保持清晰、整洁的状态进行迭代，对社区对项目都是有益的。
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
> the rePut method I think will be re-added soon in the future
This is certainly very good. Could you add a `Timeout` parameter to
`doRun()` and `run()` when the `reput` is re-added? It is beneficial for both
the community and the project to keep open source code in a clear and tidy
state for iteration as much as possible.
这非常好。那能不能在`rePut`被重新添加回来时，再给`doRun()`和`run()`加上`Timeout`入参呢？让开源代码尽量保持清晰、整洁的状态进行迭代，对社区对项目都是有益的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
