[ 
https://issues.apache.org/jira/browse/FINERACT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209756#comment-17209756
 ] 

Aleksandar Vidakovic commented on FINERACT-1171:
------------------------------------------------

[~ptuomola] [~vorburger] just wanted to let you know that I made quite some 
progress here. Maybe we could get together one of these days to show you around?

I've managed to integrate fineract-client as a module (instead of 
Bash-script-magic approach we have currently). Like that we can publish it to 
Maven Central (which I think we should). I've added a placeholder for 
"fineract-api" (just an empty folder for now; will only continue after merging 
back to develop). And overall I've also modularized the build.gradle files 
themselves; not sure if you'll like it (although I do hope)... it's just that 
the one Gradle file got really awefully long and I found it a bit of a pain 
when trying to adjust things and finding the right section in over 1000 LOC; 
the new build.gradle for fineract-provider is only around 200 LOC. Rearranging 
things also revealed that some files were not covered by Spotless, Spotbug, 
Rat, Errorprone (as far as I remember some minor stuff in the SQL files and a 
handful more); just by re-arranging things for multi-module we got those 
included as well.

Experimental: I integrated a Gradle plugin that allows us to pick the version 
number from the current Git environment; on releases it will pick automatically 
the release version... no more manual editing of gradle.properties (at least I 
hope).

I have one dirty trick left to iron out (a little bit of a chicken and egg 
problem in the relation between the modules of "fineract-client" and 
"fineract-provider"). I found a solution for now that let's us keep everything 
up to date and build it.

Besides the fineract-api module I have already another candidate to add here: 
documentation. I will port the few existing pages we have in the docs folder to 
Asciidoc (with PlantUML for diagrams). Have set this up on a couple of projects 
recently... the results are really nice... it's easy to edit (aka 
"documentation as source code"). This will take me only a couple of hours to 
setup; will send you the ticket and PR when ready.

Current changes can be found here: 
https://github.com/vidakovic/fineract/tree/feature/FINERACT-1171

> Multi-module configuration for Gradle
> -------------------------------------
>
>                 Key: FINERACT-1171
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1171
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.5.0
>            Reporter: Aleksandar Vidakovic
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Use the build.gradle file in the root folder rather than in fineract-provider 
> to import the project in IDEs.
> Note: this will force everyone to re-import the project in their IDEs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to