[
https://issues.apache.org/jira/browse/FINERACT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209984#comment-17209984
]
Petri Tuomola commented on FINERACT-1171:
-----------------------------------------
[~aleks] - that's amazing - great work! You've really moved the build process
and Gradle scripts forwards by a huge amount.
I took a quick look at the code - will look more closely later - but overall
this is a great idea. I suppose the questions I would be keen to check are:
# I use Eclipse instead of IntelliJ - so will check if this still works in
Eclipse as it did before
# If we move to use the BOMs for dependencies more actively, does Renovate
still do something sensible (i.e. tell us when we need to upgrade the BOM
version)? I recently noticed that we were referring to an old Spring Framework
BOM and manually created a PR to upgrade this - if we use BOMs then in my view
it would be good for Renovate to tell us when to upgrade.
# Does the jgitver plugin also do something sensible if you are building
outside a git repository? The previous code we had for determining version
numbers from git initially failed the build if you were not in a repository -
which is clearly not a good idea
> Multi-module configuration for Gradle
> -------------------------------------
>
> Key: FINERACT-1171
> URL: https://issues.apache.org/jira/browse/FINERACT-1171
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5.0
> Reporter: Aleksandar Vidakovic
> Assignee: Aleksandar Vidakovic
> Priority: Major
> Fix For: 1.5.0
>
>
> Use the build.gradle file in the root folder rather than in fineract-provider
> to import the project in IDEs.
> Note: this will force everyone to re-import the project in their IDEs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
