[ 
https://issues.apache.org/jira/browse/FINERACT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210443#comment-17210443
 ] 

Aleksandar Vidakovic commented on FINERACT-1171:
------------------------------------------------

[~ptuomola] found the Eclipse error... you were right, was a wrong path in the 
OpenJPA launcher configuration; this is fixed now.

As for jgitver without Git: yes, I think jgitver would not work properly for 
that use case; but what we could do is to "etch" the version number permanently 
into the build.gradle version variable as part of the release process; I can 
enable jgitver conditionally... if we detect that we are not in a Git 
environment then we fall back to the version number in the build.gradle file.

And yes, at the moment jgitver claims the version 1.3.1 (it automatically 
increases the patch version to hint that we are developing towards 1.3.1); that 
is obviously "wrong"... but only because of the way we did the release in a 
separate branch (aka no release tag a la "git tag -a 1.4.0"). I think we can 
fix that and adapt slightly different release rules the next time (I think you 
preferred to have that tag anyway).

> Multi-module configuration for Gradle
> -------------------------------------
>
>                 Key: FINERACT-1171
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1171
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.5.0
>            Reporter: Aleksandar Vidakovic
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>             Fix For: 1.5.0
>
>         Attachments: image-2020-10-08-21-19-43-775.png, 
> image-2020-10-08-21-43-03-567.png, image-2020-10-08-21-48-56-177.png, 
> image-2020-10-08-21-52-46-940.png
>
>
> Use the build.gradle file in the root folder rather than in fineract-provider 
> to import the project in IDEs.
> Note: this will force everyone to re-import the project in their IDEs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to