[
https://issues.apache.org/jira/browse/FINERACT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210868#comment-17210868
]
Michael Vorburger commented on FINERACT-1171:
---------------------------------------------
[~aleks] this is incredible!! If I had to make only 1 feedback, it would be to
encourage you to start, slowly and step by step, let this trickle into small
easy to review Pull Requests, each focused on a specific step. Your branch is
already too large for me to be motivated to really properly review the diff.
(Hope you don't mind me saying this, I'm super excited to see this, and trying
to help how we can get it "in".) What I personally do in such cases, to not let
my innovative enthusiasm be slowed down when I'm on a roll like you clearly are
here, is that I also work on a branch in my repo where I can push ahead, but I
then start raising a first PR, and then I keep rebasing my branch, which keeps
getting smaller and smaller, over and over again, until everything made it
"upstream" and my branch becomes "empty".
GitHub unfortunately doesn't support this as nicely as Gerrit does with
"dependencies" among changes, so the simplest is to get started raising just 1
PR, let us review, merge, then you rebase your branch, and you raise a PR for
the next thing that we can review and get merged in, and then rinse and repeat.
(If you raise several PRs from the start, it's more painful for you, and
doesn't make the code review much easier.)
Maybe start with some real simple stuff (the reformatting fixes which you found
that SpotBugs didn't cover before? what's it with those Gradle changes?) and
then "work your way up". If you want any help or input on how to "structure"
this a bit, if you want, one idea could be to start raising sub-tasks under
this "umbrella" issue? You got a bunch of really cool things going here - each
of which is worth a line in future release notes! (Generated from JIRAs.)
Sounds like a plan?
> Multi-module configuration for Gradle
> -------------------------------------
>
> Key: FINERACT-1171
> URL: https://issues.apache.org/jira/browse/FINERACT-1171
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5.0
> Reporter: Aleksandar Vidakovic
> Assignee: Aleksandar Vidakovic
> Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2020-10-08-21-19-43-775.png,
> image-2020-10-08-21-43-03-567.png, image-2020-10-08-21-48-56-177.png,
> image-2020-10-08-21-52-46-940.png
>
>
> Use the build.gradle file in the root folder rather than in fineract-provider
> to import the project in IDEs.
> Note: this will force everyone to re-import the project in their IDEs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
