[ 
https://issues.apache.org/jira/browse/FINERACT-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216156#comment-17216156
 ] 

Michael Vorburger commented on FINERACT-1212:
---------------------------------------------

> Some of these auto-numbered functions might come from the fact that we have 
> multiple similar REST endpoints that are handled by functions with the same 
> name (just different parameters) and somehow this creates a name conflict in 
> the client code.

Yeah, but No, not really; e.g. 
{{org.apache.fineract.client.services.ClientApi}} has only 1 single 
{{retrieveAll*}} named method, so there is no _namespace clashing_ here that 
needs to be resolved. I don't doubt it 's related to something in Swagger 
CodeGen it should do that, but it doesn't seem right / be required.

I did a quick web search, and couldn't immediately easily come up with much, 
but did stumble upon e.g. https://github.com/springfox/springfox/issues/1224, 
which sounds very vaguely related. But it would take more investigation. I'll 
add the Beginner tag, in case a new contributor perhaps wants to take the time 
to dig more into this some time.

> But the real issue here is the way the whole REST API layer in Fineract is 
> built.

Agreed, but that is a completely separate issue, not "directly" related to this 
problem, I suspect. Let's fork that off into FINERACT-1217.

> SDK Swagger Client Java API method names are ugly
> -------------------------------------------------
>
>                 Key: FINERACT-1212
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1212
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Priority: Major
>              Labels: beginner
>
> I am, for the first time, attempting to fool around with our shiny new SDK 
> Client Java API, for FINERACT-1209.
> It seems that its method names are a bit ugly - what is e.g. that *20 suffix 
> in {{org.apache.fineract.client.services.ClientApi.retrieveAll20()}} for?
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to