[
https://issues.apache.org/jira/browse/FINERACT-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216163#comment-17216163
]
Aleksandar Vidakovic commented on FINERACT-1212:
------------------------------------------------
Just note to self: in the end this might be actually not as difficult to solve.
Have a feeling that this is just related to functions called "retrieveAll"
which we have all over the place in all resources. I've identified the
following function names that get duplicated:
* retrieveOne
* retrieveAll
* update
* create
* template
* retrieveAllAccounts
* handleCommands
* getAddress
* retrieveTemplate
* activate
* delete
* retrieveCollateralDetails
* executeLoanCharge
* retrieveGuarantorDetails
* deleteCode
* transaction
* adjustTransaction
* submitApplication
* retrieveImage
* addNewClientImage
* deleteClientImage
* retrieveClientCharge
* retrieveAllClientCharges
* retrieveObligeeDetails
* retrieveAllClientTransactions
* retrieveClientTransaction
* retrieveAssociatedAccounts
* retrieveTransaction
* retrieveAllLoanCharges
* retrieveLoanCharge
* retrieveLoan
* modifyLoanApplication
* stateTransitions
* calculateLoanScheduleOrSubmitLoanApplication
* retrieveAllLoanProducts
* retrieveLoanProductDetails
* retrieveAllProducts
* retrieveProduct
* runReport
* retrieveAllSavingsAccountCharges
* retrieveSavingsAccountCharge
* authenticate
* fetchAuthenticatedUserData
* createAccount
* createScorecard
* findByClient
* fetchAllSurveys
* retrieve
The easiest way to get to that list above is to search "fineract.yaml" with the
following regex: operationId:.*_1$
These are 70 function name patterns that somehow are considered to have
duplicates by the code generator. Half of that list has very few occurrences
(maybe 2 or 3) vs those with many (retrieveAll).
> SDK Swagger Client Java API method names are ugly
> -------------------------------------------------
>
> Key: FINERACT-1212
> URL: https://issues.apache.org/jira/browse/FINERACT-1212
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Priority: Major
> Labels: beginner
>
> I am, for the first time, attempting to fool around with our shiny new SDK
> Client Java API, for FINERACT-1209.
> It seems that its method names are a bit ugly - what is e.g. that *20 suffix
> in {{org.apache.fineract.client.services.ClientApi.retrieveAll20()}} for?
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
