vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924374504
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartReadServiceImpl.java:
##########
@@ -143,19 +128,13 @@ public InterestRateChartData
retrieveWithTemplate(InterestRateChartData chartDat
final List<CodeValueData> clientClassificationOptions = new
ArrayList<>(
this.codeValueReadPlatformService.retrieveCodeValuesByCode(ClientApiConstants.CLIENT_CLASSIFICATION));
return InterestRateChartData.withTemplate(chartData,
this.chartDropdownReadPlatformService.retrievePeriodTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveEntityTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveAttributeNameOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveConditionTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveIncentiveTypeOptions(),
genderOptions, clientTypeOptions,
+
this.interestIncentiveDropdownReadService.retrieveEntityTypeOptions(),
Review Comment:
I know that "we" use a lot of "this." in the rest of the code base... but
there is absolutely no way of confusion... the prefix "this." is really
distracting... let's remove... we know that this is an injected dependency and
that it is a class variable/attribute... so, let's keep it short and crisp,
because "this." is not adding any value here (just strain on the eyes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
