vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924394277
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabsReadServiceImpl.java:
##########
@@ -104,37 +104,35 @@ public InterestRateChartSlabData retrieveTemplate() {
final List<CodeValueData> clientClassificationOptions = new
ArrayList<>(
this.codeValueReadPlatformService.retrieveCodeValuesByCode(ClientApiConstants.CLIENT_CLASSIFICATION));
return
InterestRateChartSlabData.template(this.chartDropdownReadPlatformService.retrievePeriodTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveEntityTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveAttributeNameOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveConditionTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveIncentiveTypeOptions(),
genderOptions, clientTypeOptions,
+
this.interestIncentiveDropdownReadService.retrieveEntityTypeOptions(),
+
this.interestIncentiveDropdownReadService.retrieveAttributeNameOptions(),
+
this.interestIncentiveDropdownReadService.retrieveConditionTypeOptions(),
+
this.interestIncentiveDropdownReadService.retrieveIncentiveTypeOptions(),
genderOptions, clientTypeOptions,
clientClassificationOptions);
}
private static final class InterestRateChartSlabsMapper implements
RowMapper<InterestRateChartSlabData> {
private final String schemaSql;
- public String schema() {
- return this.schemaSql;
+ private InterestRateChartSlabsMapper(DatabaseSpecificSQLGenerator
sqlGenerator) {
+
+ String sqlBuilder = "ircd.id as ircdId, ircd.description as
ircdDescription, ircd.period_type_enum ircdPeriodTypeId, "
Review Comment:
How about using multiline strings ("triple double quotes")? Then this string
concatenation thing (which is anyway only enforced by the code
formatter/linter) goes away and people can actually ready this properly (and
for you it's a ton easier to format the SQL statement in any way you seem fit).
Multiline strings won't be touched by the code formatter/linter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
