vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924379190
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabsReadServiceImpl.java:
##########
@@ -86,10 +86,10 @@ public InterestRateChartSlabData
retrieveWithTemplate(InterestRateChartSlabData
this.codeValueReadPlatformService.retrieveCodeValuesByCode(ClientApiConstants.CLIENT_CLASSIFICATION));
return InterestRateChartSlabData.withTemplate(chartSlab,
this.chartDropdownReadPlatformService.retrievePeriodTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveEntityTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveAttributeNameOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveConditionTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveIncentiveTypeOptions(),
genderOptions, clientTypeOptions,
+
this.interestIncentiveDropdownReadService.retrieveEntityTypeOptions(),
Review Comment:
"this."
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartSlabsReadServiceImpl.java:
##########
@@ -104,37 +104,35 @@ public InterestRateChartSlabData retrieveTemplate() {
final List<CodeValueData> clientClassificationOptions = new
ArrayList<>(
this.codeValueReadPlatformService.retrieveCodeValuesByCode(ClientApiConstants.CLIENT_CLASSIFICATION));
return
InterestRateChartSlabData.template(this.chartDropdownReadPlatformService.retrievePeriodTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveEntityTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveAttributeNameOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveConditionTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveIncentiveTypeOptions(),
genderOptions, clientTypeOptions,
+
this.interestIncentiveDropdownReadService.retrieveEntityTypeOptions(),
Review Comment:
"this."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
