vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924450681
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/starter/InterestRateChartConfiguration.java:
##########
@@ -51,94 +44,71 @@
public class InterestRateChartConfiguration {
@Bean
- @ConditionalOnMissingBean(InterestIncentiveAssembler.class)
- public InterestIncentiveAssembler
interestIncentiveAssembler(FromJsonHelper fromApiJsonHelper) {
- return new InterestIncentiveAssembler(fromApiJsonHelper);
- }
-
- @Bean
-
@ConditionalOnMissingBean(InterestIncentiveDropdownReadPlatformService.class)
- public InterestIncentiveDropdownReadPlatformService
interestIncentiveDropdownReadPlatformService(
+ @ConditionalOnMissingBean(InterestIncentiveDropdownReadService.class)
+ public InterestIncentiveDropdownReadService
interestIncentiveDropdownReadPlatformService(
Review Comment:
Let's drop also the "Platform" from the function name, then it matches the
class name (and the way Spring would name these beans... because it actually
takes the function names for naming the beans in the internal applications
context).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
