vidakovic commented on code in PR #6013:
URL: https://github.com/apache/fineract/pull/6013#discussion_r3538136562
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/SecurityConfig.java:
##########
@@ -379,6 +379,15 @@ public SecurityFilterChain filterChain(HttpSecurity http)
throws Exception {
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"CREATE_STAFF")
.requestMatchers(API_MATCHER.matcher(HttpMethod.PUT,
"/api/*/staff/*"))
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"UPDATE_STAFF")
+ // floatingrate
Review Comment:
Don't insert blocks like this in the middle of a list... this will create
uglier Git conflicts than necessary for yourself and other devs working here.
Please move at the end of the definitions... a lot easier to merge. Seems
trivial, but in fact can annoy yourself and other devs quite a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
