vidakovic commented on code in PR #6013:
URL: https://github.com/apache/fineract/pull/6013#discussion_r3538163358
##########
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/domain/FloatingRate.java:
##########
@@ -132,32 +104,31 @@ public List<FloatingRatePeriod> getFloatingRatePeriods() {
return this.floatingRatePeriods;
}
- public Map<String, Object> update(final JsonCommand command) {
+ public Map<String, Object> update(final FloatingRateUpdateRequest request,
final List<FloatingRatePeriod> newRatePeriods) {
Review Comment:
It would be better to do this in the service class. I am pretty sure this
function gets called only in 1 place. Let's not bury this in the entity classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
