vidakovic commented on code in PR #6013:
URL: https://github.com/apache/fineract/pull/6013#discussion_r3538169455
##########
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/serialization/FloatingRateDataValidator.java:
##########
@@ -46,176 +46,63 @@ public class FloatingRateDataValidator {
public static final String NAME = "name";
public static final String IS_BASE_LENDING_RATE = "isBaseLendingRate";
- public static final String IS_ACTIVE = "isActive";
public static final String RATE_PERIODS = "ratePeriods";
public static final String FROM_DATE = "fromDate";
public static final String INTEREST_RATE = "interestRate";
public static final String IS_DIFFERENTIAL_TO_BASE_LENDING_RATE =
"isDifferentialToBaseLendingRate";
- public static final String LOCALE = "locale";
- public static final String DATE_FORMAT = "dateFormat";
public static final String FLOATINGRATE = "floatingrate";
- private static final Set<String> SUPPORTED_PARAMETERS_FOR_FLOATING_RATES =
new HashSet<>(
- Arrays.asList(NAME, IS_BASE_LENDING_RATE, IS_ACTIVE,
RATE_PERIODS));
- private static final Set<String>
SUPPORTED_PARAMETERS_FOR_FLOATING_RATE_PERIODS = new HashSet<>(
- Arrays.asList(FROM_DATE, INTEREST_RATE,
IS_DIFFERENTIAL_TO_BASE_LENDING_RATE, LOCALE, DATE_FORMAT));
- private final FromJsonHelper fromApiJsonHelper;
private final FloatingRateRepository floatingRateRepository;
@Autowired
Review Comment:
Annotation not needed! Spring understands constructor injection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
