adamsaghy commented on code in PR #6588:
URL: https://github.com/apache/fineract/pull/6588#discussion_r4308325441
##########
fineract-e2e-tests-runner/src/test/java/org/apache/fineract/test/initializer/global/LoanProductGlobalInitializerStep.java:
##########
@@ -5298,6 +5298,106 @@ public void initialize() throws Exception {
responseLoanProductsRequestLP2AdvPmntIntEmi36030IntRecalcDailyMultiDisburseAutoDownpaymentAccelerateMaturity);
});
+ tasks.add(() -> {
+ // LP1 monthly with actual/actual interest and LAST_DAY_OF_MONTH
strategy
+ String name181 =
DefaultLoanProduct.LP1_MONTHLY_END_DUE_DATE_CLAMP_CUMULATIVE.getName();
Review Comment:
**Change request – CI is red because of this.**
`run-regression-safety-db-changes` starts the *baseline* (develop) backend and
runs this PR's e2e runner against it. The global initializer runs before tag
filtering, so it tries to create these new products on a backend that does not
know the field. Every one of them fails with `The parameter
monthEndDueDateStrategy is not supported` (400), and the run aborts with
`Parallel loan cleanup failed` ([job
log](https://github.com/apache/fineract/actions/runs/38872202557/job/116886463967)).
Could you create these products where the feature needs them (for example in
the feature's own Background / step defs) instead of in the global initializer,
or otherwise make the job pass? As it stands, the check fails for the PR
itself, not because of something flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
