Cocoa-Puffs commented on code in PR #6588:
URL: https://github.com/apache/fineract/pull/6588#discussion_r4312092107
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -4159,7 +4172,8 @@ private void
handleReAgeWithCommonStrategy(LoanTransaction loanTransaction, Comm
reAgedInstallmentIndex++;
for (int i = 1; i < numberOfReAgeInstallments; i++) {
final LocalDate calculatedDueDate =
scheduledDateGenerator.getRepaymentPeriodDate(loanReAgeParameter.getFrequencyType(),
- loanReAgeParameter.getFrequencyNumber() * i,
loanReAgeParameter.getStartDate());
+ loanReAgeParameter.getFrequencyNumber() * i,
loanReAgeParameter.getStartDate(),
+
LoanConfigurationDetailsMapper.monthEndDueDateStrategy(loan,
loanMeetingCalendarService));
Review Comment:
the strategy is now looked up once, before the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
