adamsaghy commented on code in PR #6588:
URL: https://github.com/apache/fineract/pull/6588#discussion_r4308325452
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java:
##########
@@ -1195,17 +1212,22 @@ public BigDecimal calculatePeriodsBetweenDates(final
LocalDate startDate, final
.add(BigDecimal.valueOf((double) daysLeftAfterWeeks /
7));
break;
case MONTHS:
- int numberOfMonths = DateUtils.getExactDifference(startDate,
endDate, ChronoUnit.MONTHS);
+ // a 1st after a month too short for the anchor day is that
month's date when rolling forward, so it
Review Comment:
Nit: spotless broke this comment across lines in the middle of a sentence
(`so it` / `counts` / `whole months ...`). Please rewrite it so it wraps
cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
