adamsaghy commented on code in PR #6588:
URL: https://github.com/apache/fineract/pull/6588#discussion_r4308325446
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -312,15 +317,21 @@ private LoanApplicationTerms
assembleLoanApplicationTermsFrom(final JsonElement
}
}
+ MonthEndDueDateStrategy monthEndDueDateStrategy =
loanProduct.getLoanProductRelatedDetail().getMonthEndDueDateStrategy();
+ if
(this.fromApiJsonHelper.parameterExists(LoanApiConstants.monthEndDueDateStrategyParameterName,
element)) {
Review Comment:
**Question – scope.** The story says the attribute is set on the product and
that the loan *inherits* it at submission. This change also accepts
`monthEndDueDateStrategy` on the loan request, so a loan can override its
product at submission and on modify (Swagger: "Overrides the loan product's
month end due date strategy for this loan", e2e UC8).
Was the loan-level override agreed with the product owner? If yes, please
add it to the story/ACs so it is documented and supported. If not, I'd drop it
here, in `LoanApplicationValidator`'s supported-parameters set, in
`updateLoanApplicationAttributes`, and in the two Swagger request fields, and
keep the loan strictly inheriting from the product.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
