Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3743#discussion_r112479103
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
 ---
    @@ -586,6 +602,13 @@ trait ImplicitExpressionOperations {
      * to [[ImplicitExpressionOperations]].
      */
     trait ImplicitExpressionConversions {
    +
    +  implicit val UNBOUNDED_ROW = toRowInterval(Long.MaxValue)
    +  implicit val UNBOUNDED_RANGE = toMilliInterval(1, Long.MaxValue)
    +
    +  implicit val CURRENT_ROW = toRowInterval(0L)
    +  implicit val CURRENT_RANGE = toMilliInterval(0L, Long.MaxValue)
    --- End diff --
    
    isn't a range interval of `0` a valid range to use? I would mean all rows 
that arrived in the same millisecond as the current row, no?
    Should we use `-1` as constant for current row instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to