Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3743#discussion_r112459590
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
 ---
    @@ -190,8 +190,8 @@ object ProjectionTranslator {
       def expandProjectList(
    --- End diff --
    
    I would not change the `expandProjectList()` method which has a dedicated 
purpose.
    
    Instead, I would add a new method to `ProjectionTranslator`, which just 
translates the over windows:
    
    ```
    def translateOverWindows(
          exprs: Seq[Expression],
          overWindows: Array[OverWindow]): Seq[Expression]
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to