Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3743#discussion_r112559640
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala
---
@@ -49,6 +57,128 @@ case class Call(functionName: String, args:
Seq[Expression]) extends Expression
}
/**
+ * Over expression for calcite over transform.
+ *
+ * @param agg over-agg expression
+ * @param aggAlias agg alias for following `select()` clause.
+ * @param overWindowAlias over window alias
+ * @param overWindow over window
+ */
+case class OverCall(
+ agg: Aggregation,
+ var aggAlias: Expression,
+ overWindowAlias: Expression,
+ var overWindow: OverWindow = null) extends Expression {
+
+ private[flink] def as(aggAlias: Expression): OverCall = {
+ this.aggAlias = aggAlias
+ this
+ }
+
+ override private[flink] def toRexNode(implicit relBuilder: RelBuilder):
RexNode = {
+
+ val rexBuilder = relBuilder.getRexBuilder
+
+ val operator: SqlAggFunction = agg.toSqlAggFunction()
+
+ val aggReturnType: TypeInformation[_] = agg.resultType
+
+ val relDataType =
SqlTypeUtils.createSqlType(relBuilder.getTypeFactory, aggReturnType)
+
+ val aggExprs: util.ArrayList[RexNode] = new util.ArrayList[RexNode]()
+ val aggChildName = agg.child.asInstanceOf[ResolvedFieldReference].name
+
+ aggExprs.add(relBuilder.field(aggChildName))
+
+ val orderKeys: ImmutableList.Builder[RexFieldCollation] =
+ new ImmutableList.Builder[RexFieldCollation]()
+
+ val sets:util.HashSet[SqlKind] = new util.HashSet[SqlKind]()
+ val orderName =
overWindow.orderBy.asInstanceOf[UnresolvedFieldReference].name
+
+ val rexNode =
+ if (orderName.equalsIgnoreCase("rowtime") ||
orderName.equalsIgnoreCase("proctime")) {
+ // for stream
+ relBuilder.literal(orderName)
--- End diff --
can we use `relBuilder.call(EventTimeExtractor)` and
`relBuilder.call(ProcTimeExtractor)` here to make the logic identical to SQL?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
