Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3743#discussion_r112469838
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
---
@@ -35,6 +37,18 @@ abstract sealed class Aggregation extends
UnaryExpression {
* Convert Aggregate to its counterpart in Calcite, i.e. AggCall
*/
private[flink] def toAggCall(name: String)(implicit relBuilder:
RelBuilder): AggCall
+
+ /**
+ * Because SqlAggFunction from Calcite's AggCallImpl is invisible,
+ * we have to manually create sqlAggFunction in flink code base.
+ *
+ */
+ private[flink] def toSqlAggFunction()(implicit relBuilder: RelBuilder):
SqlAggFunction
+
+ /**
+ * Attach the Resolved Child to aggregation
+ */
+ private[flink] def withResolvedChild(child: Expression): Aggregation
--- End diff --
remove the `withResolvedChild()` method as we validate the aggregation
argument with the default validation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
