[
https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008350#comment-16008350
]
ASF GitHub Bot commented on FLINK-6462:
---------------------------------------
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3851
Hi @fhueske, Thanks for the reviewing.
I forgot to run the `mvn verify` at the first time. Sorry for that.:(
I had update the PR. according your comments. Except one,i.e.:
Move `scala/batch/table/AggregationsTest.scala#testOverAggregation` to
`AggregationsValidationTest`. Because `AggregationsTest` should extends
`TableTestBase`. And `AggregationsValidationTest` need not.
What do you think?
Thanks,
SunJincheng
> Add requiresOver interface for AggregateFunction
> -------------------------------------------------
>
> Key: FLINK-6462
> URL: https://issues.apache.org/jira/browse/FLINK-6462
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window,
> such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do
> not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined
> AGG need to be clearly defined. In calcite `SqlAggFunction` will using
> `requiresOver` to distinguish.
> In this JIRA. will deal with this feature.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
