[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064584#comment-16064584
 ] 

ASF GitHub Bot commented on FLINK-6998:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4187
  
    Please resolve the checkstyle violations:
    ```
    
    [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java:[96]
 (javadoc) JavadocStyle: First sentence should end with a period.
    [ERROR] 
src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java:[99]
 (javadoc) JavadocStyle: First sentence should end with a period.
    ```


> Kafka connector needs to expose metrics for failed/successful offset commits 
> in the Kafka Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6998
>                 URL: https://issues.apache.org/jira/browse/FLINK-6998
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Zhenzhong Xu
>            Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in 
> KafkaConsumerThread class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)