[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065595#comment-16065595
 ] 

ASF GitHub Bot commented on FLINK-6998:
---------------------------------------

Github user zhenzhongxu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4187#discussion_r124413737
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
       </tbody>
     </table>
     
    +#### Connector:
    +<table class="table table-bordered">
    +  <thead>
    +    <tr>
    +      <th class="text-left" style="width: 20%">Scope</th>
    +      <th class="text-left" style="width: 30%">Metrics</th>
    +      <th class="text-left" style="width: 50%">Description</th>
    +    </tr>
    +  </thead>
    +  <tbody>
    +    <tr>
    +      <th rowspan="1">Slot/Consumer</th>
    +      <td>kafkaCommitsSucceeded</td>
    +      <td>Kafka offset commit success count if Kafka commit is turned 
on.</td>
    --- End diff --
    
    Sure, thanks for the feedback. Will update.a


> Kafka connector needs to expose metrics for failed/successful offset commits 
> in the Kafka Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6998
>                 URL: https://issues.apache.org/jira/browse/FLINK-6998
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Zhenzhong Xu
>            Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in 
> KafkaConsumerThread class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)