[
https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065620#comment-16065620
]
ASF GitHub Bot commented on FLINK-6998:
---------------------------------------
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4187
@tzulitai
**Regarding the metric naming:**
Any suggestions on naming conventions for these flink specific metrics? How
do you like 'kafkaconnector-commits-succeeded' (component-metric-name) as an
example? I personally like hyphen seperators better than camel case for metric
names.
I'll not include the other proposed metric in this PR just for the sake of
simplicity. I also have some opinions on "offset lag" metric, I think this
particular metric is more useful when some external entity
perform the monitoring (difference of committed offset vs log head),
especially in failure situations.
**Regarding the implementation:**
Thanks for the feedback. I'll explore the more proper implementation
suggested, I'll get back to you with a solution or question.
> Kafka connector needs to expose metrics for failed/successful offset commits
> in the Kafka Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
> Key: FLINK-6998
> URL: https://issues.apache.org/jira/browse/FLINK-6998
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Zhenzhong Xu
> Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in
> KafkaConsumerThread class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
