[
https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064597#comment-16064597
]
ASF GitHub Bot commented on FLINK-6998:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4187
Hi @zhenzhongxu, thanks for the PR. I like the idea of exposing these
metrics.
Regarding the metric naming:
I think we also expose metrics that are directly available through the
Kafka client.
Apart from this PR, there was also previous discussion about adding other
Flink-specific metrics to the connector (e.g., offset lag since last
checkpoint).
I wonder whether or not we should regulate the naming scheme for these
Flink-specific metrics, to set them apart from Kafka's provided metrics. What
do you think?
> Kafka connector needs to expose metrics for failed/successful offset commits
> in the Kafka Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
> Key: FLINK-6998
> URL: https://issues.apache.org/jira/browse/FLINK-6998
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Zhenzhong Xu
> Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in
> KafkaConsumerThread class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
