[
https://issues.apache.org/jira/browse/FLINK-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108849#comment-16108849
]
ASF GitHub Bot commented on FLINK-7312:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4447
At the first quick glance: This is removing a lot of `final` keywords from
various methods.
While one could argue that this keyword is not strictly necessary (the
class as a whole is final), I put them there on purpose when writing this
originally, to "document" the intention that these methods should not be ever
overridden, regardless of whether the class as a whole would be subclass-able.
I would vote to leave this in place, actually. While actually improving /
cleaning up bad code is a nice thing to do as part of reworking parts, I think
this is good practice to not try and just change things that could be changed,
just for the sake of changing them, or because of a personal view of "what
would look nicer".
There is frequently a reason why things are as they are, especially in
modules like the memory segments that were written very carefully and
consciously.
> activate checkstyle for flink/core/memory/*
> -------------------------------------------
>
> Key: FLINK-7312
> URL: https://issues.apache.org/jira/browse/FLINK-7312
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle, Core
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
