[ 
https://issues.apache.org/jira/browse/FLINK-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108884#comment-16108884
 ] 

ASF GitHub Bot commented on FLINK-7312:
---------------------------------------

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4447
  
    FYI: the `final` keyword on methods in `final` classes is something that is 
actually forbidden by the checkstyle, hence the change
    
    Regarding the try-catch in tests (actually part of #4446): you're right, I 
was too quick in arguing that stack traces are not printed - whenever there is 
a `e.printStackTrace()`, it should work but at least when developing with 
IntelliJ, this printout is not clickable (during debugging a failure) compared 
to failing with a proper exception.


> activate checkstyle for flink/core/memory/*
> -------------------------------------------
>
>                 Key: FLINK-7312
>                 URL: https://issues.apache.org/jira/browse/FLINK-7312
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle, Core
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to