[
https://issues.apache.org/jira/browse/FLINK-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108856#comment-16108856
]
ASF GitHub Bot commented on FLINK-7312:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4447
There is also a complete reorg of a test file, removing try/catch blocks.
This affects to my knowledge only the way where exactly the stack trace is
printed.
I am skeptical about these types of refactorings:
- Either the reviewer does not really look at them, in which case the
danger of accidentally weakening the test coverage by far outweigh the (in my
opinion quite subjective and cosmetic) benefits of such a change.
- Or the reviewer really checks the diff, in which case I would suggest
to dedicate that time to other pull requests that bring in actual improvements.
> activate checkstyle for flink/core/memory/*
> -------------------------------------------
>
> Key: FLINK-7312
> URL: https://issues.apache.org/jira/browse/FLINK-7312
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle, Core
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
