[
https://issues.apache.org/jira/browse/FLINK-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109167#comment-16109167
]
ASF GitHub Bot commented on FLINK-7312:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4447
Thinking more about this, I think we should modify the checkstyle to not
force us to remove such `final` keywords. While being redundant in the current
"snapshot" of the code, they may not be redundant in the future. I think there
is a big upside of writing code in a "future proof" way.
The modifiers in this class are a good example of that - the JIT
friendlyness of the methods is so important that they should not be affected by
future changes the class hierarchy.
> activate checkstyle for flink/core/memory/*
> -------------------------------------------
>
> Key: FLINK-7312
> URL: https://issues.apache.org/jira/browse/FLINK-7312
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle, Core
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
