[
https://issues.apache.org/jira/browse/FLINK-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127192#comment-16127192
]
ASF GitHub Bot commented on FLINK-6805:
---------------------------------------
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/4545
[FLINK-6805] [Cassandra-Connector] Shade indirect netty4 dep in pom.xml
## Brief change log
- To relocate various *indirect* netty4 dep of ver 4.0.33.Final to
classpath of Flink's flavor using Maven shade plugin.
## Verifying this change
- Passed local `mvn clean verify` as well as TravisCI tests
## What is the purpose of the change
- Shade *(indirect)* netty4 dependencies to avoid class clash in the
future.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
**slightly related**, shade a netty4 dep.
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no /
don't know) no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented) N.A.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcfongtw/flink FLINK-6805
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4545
----
commit f852eccd24b44ceece6e74bc06c24a77a9acb151
Author: Michael Fong <mcfong.o...@gmail.com>
Date: 2017-08-15T06:22:23Z
[FLINK-6805] [Cassandra-Connector] Shade indirect netty4 dep
To relocate various *indirect* netty4 dep of ver 4.0.33.Final to
classpath of Flink flavor using Maven shade plugin.
----
> Flink Cassandra connector dependency on Netty disagrees with Flink
> ------------------------------------------------------------------
>
> Key: FLINK-6805
> URL: https://issues.apache.org/jira/browse/FLINK-6805
> Project: Flink
> Issue Type: Bug
> Components: Cassandra Connector
> Affects Versions: 1.3.0, 1.2.1
> Reporter: Shannon Carey
> Assignee: Michael Fong
> Fix For: 1.4.0
>
>
> The Flink Cassandra connector has a dependency on Netty libraries (via
> promotion of transitive dependencies by the Maven shade plugin) at version
> 4.0.33.Final, which disagrees with the version included in Flink of
> 4.0.27.Final which is included & managed by the parent POM via dependency on
> netty-all.
> Due to use of netty-all, the dependency management doesn't take effect on the
> individual libraries such as netty-handler, netty-codec, etc.
> I suggest that dependency management of Netty should be added for all Netty
> libraries individually (netty-handler, etc.) so that all Flink modules use
> the same version, and similarly I suggest that exclusions be added to the
> quickstart example POM for the individual Netty libraries so that fat JARs
> don't include conflicting versions of Netty.
> It seems like this problem started when FLINK-6084 was implemented:
> transitive dependencies of the flink-connector-cassandra were previously
> omitted, and now that they are included we must make sure that they agree
> with the Flink distribution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
