[
https://issues.apache.org/jira/browse/FLINK-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128581#comment-16128581
]
ASF GitHub Bot commented on FLINK-6805:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4545#discussion_r133407236
--- Diff: flink-connectors/flink-connector-cassandra/pom.xml ---
@@ -83,6 +85,10 @@ under the License.
<exclude>com.google.inject.**</exclude>
</excludes>
</relocation>
+ <relocation>
+
<pattern>io.netty</pattern>
+
<shadedPattern>org.apache.flink.shaded.netty4.io.netty</shadedPattern>
--- End diff --
1) We haven't written them down anywhere; but there are examples on how the
pattern should look like in many modules. (Granted, there are some relocations
that don't follow the points I made; standardizing them is a work-in-progress)
I would generally refer to existing relocations instead of some document that
is bound to be out-dated at some point.
2) Currently we shade&relocate dependencies that already caused conflicts.
3) Yes, but there is no better solution. While it is possible to re-use
some dependencies from Flink this tends to be a maintaining nightmare, as an
upgrade to a dependency can suddenly cause issues in another part. The netty
shading is a perfect example of this: we replaced the netty dependency and now
the connector is broken.
> Flink Cassandra connector dependency on Netty disagrees with Flink
> ------------------------------------------------------------------
>
> Key: FLINK-6805
> URL: https://issues.apache.org/jira/browse/FLINK-6805
> Project: Flink
> Issue Type: Bug
> Components: Cassandra Connector
> Affects Versions: 1.3.0, 1.2.1
> Reporter: Shannon Carey
> Assignee: Michael Fong
> Fix For: 1.4.0
>
>
> The Flink Cassandra connector has a dependency on Netty libraries (via
> promotion of transitive dependencies by the Maven shade plugin) at version
> 4.0.33.Final, which disagrees with the version included in Flink of
> 4.0.27.Final which is included & managed by the parent POM via dependency on
> netty-all.
> Due to use of netty-all, the dependency management doesn't take effect on the
> individual libraries such as netty-handler, netty-codec, etc.
> I suggest that dependency management of Netty should be added for all Netty
> libraries individually (netty-handler, etc.) so that all Flink modules use
> the same version, and similarly I suggest that exclusions be added to the
> quickstart example POM for the individual Netty libraries so that fat JARs
> don't include conflicting versions of Netty.
> It seems like this problem started when FLINK-6084 was implemented:
> transitive dependencies of the flink-connector-cassandra were previously
> omitted, and now that they are included we must make sure that they agree
> with the Flink distribution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
