[
https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268623#comment-16268623
]
ASF GitHub Bot commented on FLINK-8150:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5093
[FLINK-8150] [flip6] Expose TaskExecutor's ResourceID as TaskExecutor id
## What is the purpose of the change
Before, the TaskExecutor's InstanceID was exposed as TaskExecutor id. This
was wrong
since the InstanceID is bound the registration of a TaskExecutor whereas the
ResourceID is bound to the lifetime of the TaskExecutor. Thus, it is better
to identify
the TaskExecutor by its ResourceID which does not change.
This commit changes the behaviour accordingly on the ResourceManager and the
TaskManagerDetailsHandler.
## Brief change log
## Verifying this change
- Added `ResourceManagerTest#testRequestTaskManagerInfo` to ensure that we
can obtain the `TaskManagerInfo` for registered `TaskExecutors`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixTaskManagerId
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5093
----
commit 415e3da9b6bc8dd6071ca98966779f73b682b658
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-11-28T11:43:39Z
[FLINK-8150] [flip6] Expose TaskExecutor's ResourceID as TaskExecutor id
Before, the TaskExecutor's InstanceID was exposed as TaskExecutor id. This
was wrong
since the InstanceID is bound the registration of a TaskExecutor whereas the
ResourceID is bound to the lifetime of the TaskExecutor. Thus, it is better
to identify
the TaskExecutor by its ResourceID which does not change.
This commit changes the behaviour accordingly on the ResourceManager and the
TaskManagerDetailsHandler.
----
> WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs
> -------------------------------------------------------------------------
>
> Key: FLINK-8150
> URL: https://issues.apache.org/jira/browse/FLINK-8150
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination, REST
> Affects Versions: 1.5.0
> Reporter: Gary Yao
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> TaskManager IDs exposed by
> {{org.apache.flink.runtime.rest.handler.taskmanager.TaskManagersHandler}}
> cannot be used as input to query TaskManager metrics with method
> {{MetricStore#getTaskManagerMetricStore(String)}}.
> *Reason*
> {{ResourceManager#requestTaskManagerInfo(Time)}} returns {{TaskManagerInfo}}
> s where the instance IDs are set to the IDs of the {{TaskExecutorConnection}}
> s. While {{ResourceManager#requestTaskManagerMetricQueryServicePaths(Time)}}
> returns the Taskmanager resource IDs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
