[ 
https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268681#comment-16268681
 ] 

ASF GitHub Bot commented on FLINK-8150:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5093#discussion_r153483098
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerInfo.java
 ---
    @@ -53,8 +53,8 @@
        public static final String FIELD_NAME_HARDWARE = "hardware";
     
        @JsonProperty(FIELD_NAME_INSTANCE_ID)
    --- End diff --
    
    Should be `FIELD_NAME_RESOURCE_ID`


> WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs
> -------------------------------------------------------------------------
>
>                 Key: FLINK-8150
>                 URL: https://issues.apache.org/jira/browse/FLINK-8150
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination, REST
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> TaskManager IDs exposed by 
> {{org.apache.flink.runtime.rest.handler.taskmanager.TaskManagersHandler}} 
> cannot be used as input to query TaskManager metrics with method 
> {{MetricStore#getTaskManagerMetricStore(String)}}.
> *Reason*
> {{ResourceManager#requestTaskManagerInfo(Time)}} returns {{TaskManagerInfo}} 
> s where the instance IDs are set to the IDs of the {{TaskExecutorConnection}} 
> s. While {{ResourceManager#requestTaskManagerMetricQueryServicePaths(Time)}} 
> returns the Taskmanager resource IDs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to