[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268686#comment-16268686 ]
ASF GitHub Bot commented on FLINK-8150: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153483875 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/ResourceIDSerializer.java --- @@ -29,16 +30,16 @@ /** * Json serializer for {@link InstanceID}. */ -public class InstanceIDSerializer extends StdSerializer<InstanceID> { +public class ResourceIDSerializer extends StdSerializer<ResourceID> { private static final long serialVersionUID = 5798852092159615938L; - protected InstanceIDSerializer() { - super(InstanceID.class); + protected ResourceIDSerializer() { + super(ResourceID.class); } @Override - public void serialize(InstanceID value, JsonGenerator gen, SerializerProvider provider) throws IOException { + public void serialize(ResourceID value, JsonGenerator gen, SerializerProvider provider) throws IOException { gen.writeString(value.toString()); --- End diff -- Maybe `value.getResourceIdString()`. > WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs > ------------------------------------------------------------------------- > > Key: FLINK-8150 > URL: https://issues.apache.org/jira/browse/FLINK-8150 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination, REST > Affects Versions: 1.5.0 > Reporter: Gary Yao > Assignee: Till Rohrmann > Priority: Blocker > Labels: flip-6 > Fix For: 1.5.0 > > > TaskManager IDs exposed by > {{org.apache.flink.runtime.rest.handler.taskmanager.TaskManagersHandler}} > cannot be used as input to query TaskManager metrics with method > {{MetricStore#getTaskManagerMetricStore(String)}}. > *Reason* > {{ResourceManager#requestTaskManagerInfo(Time)}} returns {{TaskManagerInfo}} > s where the instance IDs are set to the IDs of the {{TaskExecutorConnection}} > s. While {{ResourceManager#requestTaskManagerMetricQueryServicePaths(Time)}} > returns the Taskmanager resource IDs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)