[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268903#comment-16268903 ]
ASF GitHub Bot commented on FLINK-8150: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153524037 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerDetailsInfo.java --- @@ -43,7 +43,7 @@ @JsonCreator public TaskManagerDetailsInfo( - @JsonDeserialize(using = InstanceIDDeserializer.class) @JsonProperty(FIELD_NAME_INSTANCE_ID) InstanceID instanceId, + @JsonDeserialize(using = ResourceIDDeserializer.class) @JsonProperty(FIELD_NAME_INSTANCE_ID) ResourceID resourceId, --- End diff -- Good point. Fixed with your commit. > WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs > ------------------------------------------------------------------------- > > Key: FLINK-8150 > URL: https://issues.apache.org/jira/browse/FLINK-8150 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination, REST > Affects Versions: 1.5.0 > Reporter: Gary Yao > Assignee: Till Rohrmann > Priority: Blocker > Labels: flip-6 > Fix For: 1.5.0 > > > TaskManager IDs exposed by > {{org.apache.flink.runtime.rest.handler.taskmanager.TaskManagersHandler}} > cannot be used as input to query TaskManager metrics with method > {{MetricStore#getTaskManagerMetricStore(String)}}. > *Reason* > {{ResourceManager#requestTaskManagerInfo(Time)}} returns {{TaskManagerInfo}} > s where the instance IDs are set to the IDs of the {{TaskExecutorConnection}} > s. While {{ResourceManager#requestTaskManagerMetricQueryServicePaths(Time)}} > returns the Taskmanager resource IDs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)