[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153794265
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyImpl.java
 ---
    @@ -96,7 +98,13 @@ public void start() throws Throwable {
     
        @Override
        public void shutdown() {
    -           super.shutdown();
    +           try {
    +                   Time timeout = Time.seconds(10L);
    +                   shutdownServer(timeout).get(timeout.toMilliseconds(), 
TimeUnit.MILLISECONDS);
    --- End diff --
    
    why not just get(10, TimeUnit.SECONDS)?


---