Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153786058
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -300,7 +333,7 @@ private void handInChannel(Channel channel) {
// Check shut down for possible race
with shut down. We
// don't want any lingering connections
after shut down,
// which can happen if we don't check
this here.
- if (shutDown.get()) {
+ if
(!clientShutdownFuture.compareAndSet(null, null)) {
--- End diff --
for clarity we should call `get()` instead of `compareAndSet` since the
setting part is a no-op anyway.
---
