Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153794621
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
 ---
    @@ -108,9 +108,33 @@ public QueryableStateClient(final InetAddress 
remoteAddress, final int remotePor
                                new DisabledKvStateRequestStats());
        }
     
    -   /** Shuts down the client. */
    -   public void shutdown() {
    -           client.shutdown();
    +   /**
    +    * Shuts down the client and returns a {@link CompletableFuture} that
    +    * will be completed when the shutdown process is completed.
    +    *
    +    * <p>If an exception is thrown for any reason, then the returned future
    +    * will be completed exceptionally with that exception.
    +    *
    +    * @return A {@link CompletableFuture} for further handling of the
    +    * shutdown result.
    +    */
    +   public CompletableFuture<?> shutdownAndHandle() {
    +           return client.shutdown();
    +   }
    +
    +   /**
    +    * Shuts down the client and waits until shutdown is completed.
    +    *
    +    * <p>If an exception is thrown, a warning is printed containing
    --- End diff --
    
    the warning is logged, not printed (generally implies stdout).


---

Reply via email to