Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153788979
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -95,15 +97,20 @@
private static final Logger LOG =
LoggerFactory.getLogger(ClientTest.class);
+ private static final FiniteDuration TEST_TIMEOUT = new
FiniteDuration(20L, TimeUnit.SECONDS);
+
// Thread pool for client bootstrap (shared between tests)
- private static final NioEventLoopGroup NIO_GROUP = new
NioEventLoopGroup();
+ private NioEventLoopGroup nioGroup;
- private static final FiniteDuration TEST_TIMEOUT = new
FiniteDuration(10L, TimeUnit.SECONDS);
+ @Before
+ public void setUp() throws Exception {
+ nioGroup = new NioEventLoopGroup();
--- End diff --
this method isn't strictly necessary; you can also do `private final
NioEventLoopGroup nioGroup = new NioEventLoopGroup()`. Then you would also no
longer need the null-check in `@After`.
---